search

cp2004 / OctoPrint-GCodeMacros

Configure custom gcode macros you can use anywhere!
https://plugins.octoprint.org/plugins/gcode_macro
GNU Affero General Public License v3.0
7 stars 2 forks source link

Conflict with Bed Visualizer? #3

Closed jp-001 closed 3 years ago

jp-001 commented 3 years ago

Version 1.1.0 breaks Bed Visualizer. FYI, Bed Visualizer uses a "macro" (@BEDLEVELVISUALIZER) for its operation. I suspect a conflict.

jneilliii commented 3 years ago

Linking relevant issue. https://github.com/jneilliii/OctoPrint-BedLevelVisualizer/issues/464

jneilliii commented 3 years ago

I suspect the issue is here @cp2004. That basically means don't return any commands through the remainder of the callbacks doesn't it. Shouldn't you be returning what comes in to go to the next plugin's hooks....

cp2004 commented 3 years ago

That was a stupid mistake, sorry! Should be fixed with the above commit, and I'll release 1.1.1 to get this out to people.

cp2004 commented 3 years ago

That should be good to go. It may take up to 24 hours for the update notification to arrive, or you can force check to install version 1.1.1. Thanks for bringing this to my attention!

jp-001 commented 3 years ago

Thank you for acting so fast.