search

cp2004 / OctoPrint-WS281x_LED_Status

Add some RGB LEDs to your printer for a quick status update!
https://plugins.octoprint.org/plugins/ws281x_led_status
GNU Affero General Public License v3.0
111 stars 26 forks source link

Fix broken images if octoprint is not at website's root #134

Closed Thelm76 closed 3 years ago

Thelm76 commented 3 years ago

This is my first pull request, so I hope I'm not making too much mistakes. I figured that images URLs are not working if octoprint is situated at http(s):///octoprint/. By making the URL relative with "./plugin/..." (like in other plugins), images work again.

Thelm76 commented 3 years ago

The URL : image

Before : image image

After (sorry for the theme) : image image

cp2004 commented 3 years ago

Thanks! I remember looking at this at some point but had completely forgotten, it will be part of the next release 🙂. Please note however, this release may not be for some time as I have a lot to do at the moment.

No problems I can see, thank you for the PR!