cp2004 / OctoPrint-WS281x_LED_Status

Add some RGB LEDs to your printer for a quick status update!
https://plugins.octoprint.org/plugins/ws281x_led_status
GNU Affero General Public License v3.0
111 stars 26 forks source link

[Request]: Custom color order for SK6812 compatible strips #221

Open pawelsky opened 3 months ago

pawelsky commented 3 months ago

What would you like implemented?

I recently came across a WS2814/SK6812 compatible strip with (unusual?) WRGB color order, which I unfortunately cannot configure properly to use with this great plugin. The closest I can get is SK6812_STRIP_BRGW but the Blue and White are swapped.

While it probably does not make sense to add each possible color order to the dropdown menu it would be good to have an option to define a custom color order.

The easiest (but probably not most user friendly) way to do it would be to define a SK6812_STRIP_CUSTOM where use could define the custom shift mask in hex (the SK6812_SHIFT_WMASK in the underlying _rpiws281x library's would probably have to be modified as well to correctly identify strips with separate white LEDs). More user friendly UI would of course be welcomed, but I can live with hexes hidden somewhere in the advanced section :)

Why should this be implemented?

To provide compatibility with more LED strip types

cp2004 commented 1 month ago

If the underlying library supports it, then I am happy for it to be in the plugin. I don't currently have time to do this or the hardware to test it with (I don't actually have SK6812 strips) - but if someone contributed it I would happily review & merge.

This plugin is long overdue an update, but I cannot put a timeframe on when I might be able to sink some time into it for now.

Apologies for the really delayed answer here, I completely missed this issue and only came looking because of the latest one that was opened.

pawelsky commented 1 month ago

To my understanding the underlying library does not support it, but I have a code modification that would enable that. I'll propose it to them and let you know if they decide to implement it.

cp2004 commented 1 month ago

Great, thanks. Keep me updated, and I'll be happy to weigh in with opinions/support if it helps push it along.

pawelsky commented 1 month ago

Raised an issue here: https://github.com/jgarff/rpi_ws281x/issues/540