search

cp2004 / OctoPrint-WS281x_LED_Status

Add some RGB LEDs to your printer for a quick status update!
https://plugins.octoprint.org/plugins/ws281x_led_status
GNU Affero General Public License v3.0
112 stars 27 forks source link

Add functionality to use white LEDs on a RGBW strip #93

Closed samwiseg0 closed 3 years ago

samwiseg0 commented 3 years ago

I have not tested this yet but here is what I have so far.

This version is tested and works. I would like to hide the white brightness bar when the checkbox is not enabled but I could not get that to work? Maybe you can offer some guidance?

Fixes #91

cp2004 commented 3 years ago

It looks good, that implementation is quite simple but allows for a good amount of usability.

Will test it tomorrow, and merge.

samwiseg0 commented 3 years ago

@cp2004 I started thinking about the logic a bit more and any compensations that were set would break the the logic for dedicated white since we were looking at the rectified values and not the original ones. So the solution imo was to process dedicated white before any color correction should be made. This allows full functionality color correction as well as dedicated white.

The only thing left would be to document that the only way dedicated white will work is if "white" is set to all 255 values and the checkbox it checked. If a user decides to change the "white" value it will not work.

cp2004 commented 3 years ago

Oh, BTW, I have potential first release candidate for 0.7.0 pencilled in to the weekend of the 20/21st of Feb, but knowing previous experience with this plugin I probably shouldn't say that, it will likely slip.

samwiseg0 commented 3 years ago

If I can figure out how the select Knockout bindings work I might be able to make it show conditionally on the type of strip selected, but I'll leave that for now since they can be really annoying. If you want to dive into KO hell, feel free lol.

Ha! I was thinking about that as well. Maybe I will take a stab at it! I am back to printing now so I cant test any changes. At lest not for another day or 2. I thought about setting up my other pi just for testing since I still have a bunch of LEDs left.

Thank you for the contribution, I don't think I would have come up with something like this so it is much appreciated 🙂.

You are most welcome. I am glad I could contribute in some way to the community. I was very motivated to make this work as I spent more money on those strips just for the functionality!

samwiseg0 commented 3 years ago

Oh, BTW, I have potential first release candidate for 0.7.0 pencilled in to the weekend of the 20/21st of Feb, but knowing previous experience with this plugin I probably shouldn't say that, it will likely slip.

Ok sounds great! For now I will be running the latest devel as that is the only way I can have my LEDs work with the dedicated white.

I did have a question about the latest build and how it works when the bed is leveling. Is it best to hit you up on discord or would you prefer I open a separate issue to discuss it?

cp2004 commented 3 years ago

I did have a question about the latest build and how it works when the bed is leveling. Is it best to hit you up on discord or would you prefer I open a separate issue to discuss it?

I don't mind, if it is a problem then probably an issue, if it is just a quick question discord is fine. There are still problems on the devel branch, I am working through a couple now with the fading in/out of effects.