search

cp2k / dbcsr

DBCSR: Distributed Block Compressed Sparse Row matrix library
https://cp2k.github.io/dbcsr/
GNU General Public License v2.0
135 stars 47 forks source link

Complement enabling ACC timers for non-ACC compilation #590

Closed hfp closed 2 years ago

alazzaro commented 2 years ago

Thanks!

hfp commented 2 years ago

Thanks!

No problem (hopefully this fixes https://buildkite.com/intel/dbcsr/builds/804).

alazzaro commented 2 years ago

But why the CI doesn't face this error? Is it something we don't build via cmake?

hfp commented 2 years ago

But why the CI doesn't face this error? Is it something we don't build via cmake?

I guess both acc_bench_smm and acc_bench_trans are not build and exercised (completely stand-alone). Regarding dbcsr_acc_test, I think dbcsr library is linked when using CMake based build. So, the issue solved here is mostly related to my Makefile based backend specific builds/tests (OpenCL and CUDA). However, this change introduced a dependency criticized earlier. A setter for timer function-pointers is perhaps preferable and avoiding the backends to depend on DBCSR/frontend.

hfp commented 2 years ago

I will eventually send another PR contributing acc_bench_smm and acc_bench_trans to be build with CMake.