cp2k / dbcsr

DBCSR: Distributed Block Compressed Sparse Row matrix library
https://cp2k.github.io/dbcsr/
GNU General Public License v2.0
135 stars 47 forks source link

ocl: test integration with #647 #649

Closed hfp closed 1 year ago

hfp commented 1 year ago
alazzaro commented 1 year ago

@hfp Is this a "replacement" of the #647 ? Please, do not merge for the moment, I would like to review #647 and test on LUMI before any merge...

hfp commented 1 year ago

@hfp Is this a "replacement" of the #647 ? Please, do not merge for the moment, I would like to review #647 and test on LUMI before any merge...

No! Please do not merge. This is simply to check if my change would solve some of the issues in #647 if @gsitaram decides to rebase/merge the upstream master. Also, I have one more change on top of #647 but I will share it as a comment.

codecov[bot] commented 1 year ago

Codecov Report

Base: 66.3% // Head: 66.2% // Decreases project coverage by -0.2% :warning:

Coverage data is based on head (24e77ee) compared to base (82f2b64). Patch coverage: 4.7% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #649 +/- ## ========================================= - Coverage 66.3% 66.2% -0.2% ========================================= Files 103 103 Lines 28653 28716 +63 ========================================= + Hits 19010 19013 +3 - Misses 9643 9703 +60 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `66.2% <4.7%> (-0.2%)` | :arrow_down: | | with-blas | `66.2% <4.7%> (-0.2%)` | :arrow_down: | | with-libxsmm | `66.2% <4.7%> (-0.2%)` | :arrow_down: | | with-mpi | `66.5% <4.7%> (-0.2%)` | :arrow_down: | | with-openmp | `65.5% <4.7%> (-0.2%)` | :arrow_down: | | without-mpi | `65.2% <4.7%> (-0.2%)` | :arrow_down: | | without-openmp | `65.3% <4.7%> (-0.2%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cp2k#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/cp2k/dbcsr/pull/649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cp2k) | Coverage Δ | | |---|---|---| | [src/mm/dbcsr\_mm\_cannon.F](https://codecov.io/gh/cp2k/dbcsr/pull/649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cp2k#diff-c3JjL21tL2RiY3NyX21tX2Nhbm5vbi5G) | `76.2% <ø> (ø)` | | | [src/mm/dbcsr\_mm\_common.F](https://codecov.io/gh/cp2k/dbcsr/pull/649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cp2k#diff-c3JjL21tL2RiY3NyX21tX2NvbW1vbi5G) | `36.8% <0.0%> (-7.3%)` | :arrow_down: | | [src/mm/dbcsr\_mm.F](https://codecov.io/gh/cp2k/dbcsr/pull/649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cp2k#diff-c3JjL21tL2RiY3NyX21tLkY=) | `85.5% <25.0%> (-1.8%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cp2k). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cp2k)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hfp commented 1 year ago

All tests passed except "Testing on Linux / build-on-rocm (OPENMP=ON) (pull_request)".