cp2k / dbcsr

DBCSR: Distributed Block Compressed Sparse Row matrix library
https://cp2k.github.io/dbcsr/
GNU General Public License v2.0
135 stars 46 forks source link

turn off and remove codecoverage checks #653

Closed hfp closed 1 year ago

hfp commented 1 year ago

I think the code coverage checks which are part of several tests (if not all) just burn energy and are mostly useless. Nobody cares about the noise, and the project calibrated the threshold just for the status quo. I think there are other means of judging the quality of contributions (and amount of coverage was never a criterion).

Disadvantages:

Alternatives:

hfp commented 1 year ago

Codecov.io seems to work again. I can still cause unreliability due to uploading data. Closing for now.

alazzaro commented 1 year ago

@hfp thanks for bringing up this discussion. I think it is still relevant, let's keep the issue open. Personally, I use to check the coverage, but I agree with you we need to revisit it...

alazzaro commented 1 year ago

I think @dev-zero remove the check, so I will close here.