Closed mkrack closed 1 year ago
@mkrack do you see any notable performance improvements?
ACK from my side: @mkrack unless you want to do it yourself, I will pull the pre-commit.ci fix into their respective commits with git absorb and force push. Essentially running this after checking out your feature branch:
git reset --soft HEAD~1
git absorb --base develop
@mkrack do you see any notable performance improvements?
I do not observe a performance boost on JURECA. There are simply too many CPU cores available per GPU (32 core per A100 while Piz Daint has only 12 cores per P100). On the other hand, you need tuned parameters for an efficient usage of the A100 GPUs, otherwise, it might be better to ignore the GPUs completely.
Did anyone try the OpenCL backend?
ACK from my side: @mkrack unless you want to do it yourself, I will pull the pre-commit.ci fix into their respective commits with git absorb and force push. Essentially running this after checking out your feature branch:
git reset --soft HEAD~1 git absorb --base develop
@dev-zero Applied git-adsorb
, but not sure, if the result is what you wanted?
ACK from my side: @mkrack unless you want to do it yourself, I will pull the pre-commit.ci fix into their respective commits with git absorb and force push. Essentially running this after checking out your feature branch:
git reset --soft HEAD~1 git absorb --base develop
@dev-zero Applied
git-adsorb
, but not sure, if the result is what you wanted?
Sorry, I forgot the git rebase -i --autosquash develop
up there (or the --and-rebase
option for git absorb
).
Sorry, I forgot the
git rebase -i --autosquash develop
up there (or the--and-rebase
option forgit absorb
).
@dev-zero Better you squash the commits.
Sorry, I forgot the
git rebase -i --autosquash develop
up there (or the--and-rebase
option forgit absorb
).@dev-zero Better you squash the commits.
Done. Sorry for the confusion. For completeness, the complete command would have been either
# to revert the commit done by the precommit.ci bot back into staged
git reset --soft HEAD~1
# to let git absorb figure out which hunks belong to which commits, commit them as fixups and then do a rebase
# ... if no reference given will automatically use the one from which this branch forked off
git absorb --and-rebase
or if manual control is wanted:
git reset --soft HEAD~1
# only generate commits
git absorb
# do the rebase with squash separately
git rebase -i --autosquash develop