cp2k / dbcsr

DBCSR: Distributed Block Compressed Sparse Row matrix library
https://cp2k.github.io/dbcsr/
GNU General Public License v2.0
135 stars 46 forks source link

Thread number has changed error if OMP_DYNAMIC=TRUE #705

Closed hfp closed 11 months ago

hfp commented 11 months ago
 *******************************************************************************
 *   ___                                                                       *
 *  /   \                                                                      *
 * [ABORT]                                                                     *
 *  \___/                        Thread number has changed                     *
 *    |                                                                        *
 *  O/|                                                                        *
 * /| |                                                                        *
 * / \                                                dbcsr_dist_methods.F:509 *
 *******************************************************************************

This issue is almost artificial and may be closed. However, the observation is about code at dbcsr_dist_methods.F:509 being incompatible with a valid OpenMP environment.

alazzaro commented 11 months ago

This is not supported, actually (by design of the library). See https://github.com/cp2k/dbcsr/issues/217 for a similar discussion...

alazzaro commented 11 months ago

We can probably relax the condition, but it will require a reimplementation of the entire threading part...

hfp commented 11 months ago

I do not want to keep this open as an issue. Perhaps we can invent a new GitHub label resembling issue like "nice to have", meanwhile I am labeling it "postpone".