search

cp2k / dbcsr

DBCSR: Distributed Block Compressed Sparse Row matrix library
https://cp2k.github.io/dbcsr/
GNU General Public License v2.0
134 stars 46 forks source link

Add CMake `PROCESSORS` properties #757

Closed LecrisUT closed 1 month ago

LecrisUT commented 5 months ago

This property will allow to properly parallelize ctest -j calls

jenkins-cscs commented 5 months ago

Can one of the admins verify this patch?

LecrisUT commented 5 months ago

Small note about TEST_MPI_RANKS. It should be fixed to 2 instead of auto in order to better take advantage of ctest parallelization

alazzaro commented 5 months ago

@LecrisUT Thanks for this PR. I like the idea to default the number of ranks to 2. Most of the tests are really intended for max 4 ranks in general... Still, it will be good to provide a way to cap the processors to the max available. I will work on that next week.

LecrisUT commented 5 months ago

Still, it will be good to provide a way to cap the processors to the max available

This is typically done via ctest -j $(nproc)

hfp commented 2 months ago

If this PR targets the next release of CP2K/DBCSR, it would be the right time to finish/conclude it.

LecrisUT commented 2 months ago

Seems like I may need this PR for #759. Tests are timing out due to parallelization there

alazzaro commented 1 month ago

Small note about TEST_MPI_RANKS. It should be fixed to 2 instead of auto in order to better take advantage of ctest parallelization

I've changed the default to be 2, see https://github.com/cp2k/dbcsr/commit/d8116fd92ca336c47cc00e2f15d73443f2b69285