search

cp2k / dbcsr

DBCSR: Distributed Block Compressed Sparse Row matrix library
https://cp2k.github.io/dbcsr/
GNU General Public License v2.0
134 stars 45 forks source link

Initialize member variables of derived types #806

Closed fstein93 closed 2 weeks ago

fstein93 commented 3 weeks ago

This PR adds default initializers to all types.

jenkins-cscs commented 3 weeks ago

Can one of the admins verify this patch?

alazzaro commented 1 week ago

@fstein93 it appears that this PR doesn't compile with GCC 8 (see https://storage.googleapis.com/cp2k-ci/dashboard_gcc8_report.txt). Any workaround? (I would personally drop GCC 8...)

oschuett commented 1 week ago

I wouldn't mind dropping GCC 8 either.

fstein93 commented 1 week ago

I think Daint runs with an earlier subversion off GCC9, so GCC 8 may cover these kinds of checks. But it is up to you to decide on the testsuite. The workaround for GCC 8 is similar to this.

fstein93 commented 1 week ago

In certain cases, I have to drop the initialisers entirely as GCC8 has issues with some of them. I will drop them with GCC8 in these cases.