search

cp2k / dbcsr

DBCSR: Distributed Block Compressed Sparse Row matrix library
https://cp2k.github.io/dbcsr/
GNU General Public License v2.0
134 stars 45 forks source link

Fix GCC8 #813

Open fstein93 opened 1 week ago

fstein93 commented 1 week ago

Follow up to #806

jenkins-cscs commented 1 week ago

Can one of the admins verify this patch?

hfp commented 1 week ago

FYI, there are macros to support version-checks; see https://github.com/cp2k/dbcsr/blob/develop/src/base/dbcsr_base_uses.f90#L45 (the comment gives an example for GCC and makes typical checks less intriguing ;-)

hfp commented 4 days ago

LGTM. However, I wonder how this interferes with the pending decision to drop GCC8?

Given this change, GCC8 can be kept.