cp2k / dbcsr

DBCSR: Distributed Block Compressed Sparse Row matrix library
https://cp2k.github.io/dbcsr/
GNU General Public License v2.0
135 stars 47 forks source link

Remove code related to parameter prediction #837

Open hfp opened 2 months ago

hfp commented 2 months ago
          My proposal is to remove all code related to prediction incl. the Jupyter notebook(s). This and future pre-commits like the Python linter rejects for instance `src/acc/libsmm_acc/notebooks/inspect_training_data.ipynb`. Without porting this code to new versions of their dependencies, the pre-commit remains red. An alternative is to exclude/green-list related failures. The real concern is the lack of testing for the prediction. Removing the code also fixes the [security warning](https://github.com/cp2k/dbcsr/security/dependabot).

Originally posted by @hfp in https://github.com/cp2k/dbcsr/issues/836#issuecomment-2325685546

alazzaro commented 2 months ago

crosslink to https://github.com/cp2k/dbcsr/issues/805