cp3-llbb / Framework

Common framework for all cp3-llbb analyses
https://github.com/cp3-llbb/cp3-llbb.github.io/wiki/CP3-llbb(met):-Getting-Started
0 stars 13 forks source link

Checks on the order of Framework config method calls #265

Closed pieterdavid closed 7 years ago

pieterdavid commented 7 years ago

implemented using a decorator class with "before", "after" and "performs" tag lists, which will enforce none of "before" flags has been set yet, all of the "after" flags have been set, and set the "performs" flags to True.

There are some limitations to the scaling of this, but I wanted to keep it reasonably light (both the implementation and amount of annotations to add) - feel free to try and break it from your config by doing things in the wrong order ;-) . It should enforce that adding/removing analyzers&producers can only be done before any of the corrections, as well as the orderings (JEC only before JER, electron smearing needs regression) that were already checked for.

pieterdavid commented 7 years ago

oops, I should have checked the test... been a bit too paranoid, I'm adding an optional argument to skip some checks

OlivierBondu commented 7 years ago

testing looks fine :smile:

many thanks!

OlivierBondu commented 7 years ago

Thanks! let's wait for jenkins to compile :)

pieterdavid commented 7 years ago

I wanted to cancel the jenkins job for the first of the two commits I just pushed, and saw that it's stuck... I tried following Sébastien's instructions, but I'm not an admin, so I can't restart the container

OlivierBondu commented 7 years ago

please test

OlivierBondu commented 7 years ago

please test