search

cp3-llbb / Framework

Common framework for all cp3-llbb analyses
https://github.com/cp3-llbb/cp3-llbb.github.io/wiki/CP3-llbb(met):-Getting-Started
0 stars 13 forks source link

Add Tau leptons producer and MET Cov Matrix #283

Closed clacaputo closed 5 years ago

clacaputo commented 6 years ago

New TauProducer added to the llbb framework: TauProducer.cc TauProducer.h

Modified: METProducer.h METProducer.cc

Modified: Framework.py

pieterdavid commented 6 years ago

Thanks for the update! The tests fail with

An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1356 event: 270939
   [1] Running path 'p'
   [2] Calling event method for module ExTreeMaker/'framework'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: ROOT::Math::SMatrix<double,2,2,ROOT::Math::MatRepSym<double,2> >
Looking for module label: METSignificance
Looking for productInstanceName: METCovariance

so there's still something not entirely correct (it could be as simple as adding framework.redoMETsSignificance() to the test configs). I didn't have time to go through the code in detail or test yet, but from a quick look at https://github.com/cp3-llbb/Framework/pull/283/commits/b77ede81c088b869cacf8f34c7a9c5d436fd649f#diff-a340f819a1cefc5ce0a473b558712dafR378 : I would call this addMETsSignificance - and I think it should actually go into https://github.com/cp3-llbb/Framework/blob/03d6d79843740ceaa5fb317eb92e51a53fdd1902/python/Tools.py#L166.

vischia commented 5 years ago

This has still conflicts in

src/classes.h
src/classes_def.xml

@clacaputo do you prefer to deal with them or can I try to solve them?

clacaputo commented 5 years ago

@vischia I will fix it and update the PR in the next days

pieterdavid commented 5 years ago

The only difference are the new branches, so the tests are happy :-) (you can generate new references that include the tau branches with the generate_reference_trees.sh script)

Branches found in output tree but not in the reference tree:
  met_CovMatrix00
  met_CovMatrix01
  met_CovMatrix10
  met_CovMatrix11
  met_jecdown_CovMatrix00
  met_jecdown_CovMatrix01
  met_jecdown_CovMatrix10
  met_jecdown_CovMatrix11
  met_jecup_CovMatrix00
  met_jecup_CovMatrix01
  met_jecup_CovMatrix10
  met_jecup_CovMatrix11
  met_jerdown_CovMatrix00
  met_jerdown_CovMatrix01
  met_jerdown_CovMatrix10
  met_jerdown_CovMatrix11
  met_jerup_CovMatrix00
  met_jerup_CovMatrix01
  met_jerup_CovMatrix10
  met_jerup_CovMatrix11
  tau_EAR03
  tau_EAR04
  tau_IDmap
  tau_chargedHadronIsoR03
  tau_chargedHadronIsoR04
  tau_decayMode
  tau_dz
  tau_gen_p4
  tau_gen_truth
  tau_has_matched_gen_particle
  tau_neutralHadronIsoR03
  tau_neutralHadronIsoR04
  tau_p4
  tau_photonIsoR03
  tau_photonIsoR04
  tau_puChargedHadronIsoR03
  tau_puChargedHadronIsoR04
  tau_relativeIsoR03
  tau_relativeIsoR03_deltaBeta
  tau_relativeIsoR03_withEA
  tau_relativeIsoR04
  tau_relativeIsoR04_deltaBeta
  tau_relativeIsoR04_withEA
pieterdavid commented 5 years ago 
  met_CovMatrix00
  met_CovMatrix01
  met_CovMatrix10
  met_CovMatrix11
  tau_IDmap
  tau_decayMode
  tau_dz
  tau_gen_p4
  tau_gen_truth
  tau_has_matched_gen_particle
  tau_p4

with jet systematic variations for the met covariance. Nice :-)

clacaputo commented 5 years ago 
All tests passed (20087 assertions in 1 test case)

status = 256

---> test Testcp3_llbbFramework had ERRORS

^^^^ End Test Testcp3_llbbFramework ^^^^
>> Tests for package cp3_llbb/Framework ran.
+ popd
~/workspace/Framework-SLC6/CMSSW/CMSSW_8_0_30/src ~/workspace/Framework-SLC6
+ grep ERRORS ../logs/slc6_amd64_gcc530/testing.log
---> test Testcp3_llbbFramework had ERRORS
Build step 'Execute shell' marked build as failure
Setting status of 79e4f88895abff3e28b68d996e926a16ddda3293 to FAILURE with url https://jenkins-cp3-llbb.web.cern.ch/job/Framework-SLC6/463/ and message: 'Build finished. '
Finished: FAILURE
pieterdavid commented 5 years ago

The error is because you forgot to update the data reference file