search

cp3-llbb / TTAnalysis

TTbar analysis for CP3 llbb framework
0 stars 4 forks source link

Fixed gen info - maybe? #34

Closed swertz closed 8 years ago

swertz commented 8 years ago

There was a bug in #33 which I didn't pick up because the number of events I've ran on for the test was too low (I've raised it a bit here).

The problem was because the "pruned_decays_from" macro calls were not correctly moved to the new way of indexing the gen particles, and the effect was a lot of "Error: more than two quarks coming from top decay" messages.

I'm not 100% sure it's fixed though: I still have a few of "Error: more than two quarks coming from top decay/Error: unknown ttbar decay." happening over the 1000 events. Is this something you've seen a lot or only on a few events? I don't see what's still broken though, so probably don't merge this one until we're sure...

OlivierBondu commented 8 years ago

I had a vaguely similar problem when I copied the ttbar MC truth from your code... Could it be some broken / incorrect initialization ?

blinkseb commented 8 years ago

AFAIM there was no error messages for any events. I'm investigating a bit on a list of known problematic events, I hope it's something easy to solve :)

blinkseb commented 8 years ago

Last commit fix the issue. I've moved around the defines to a new header, it became a bit hard to read in middle of the code since I added debug statements inside.