cpacia / BitcoinCash-Wallet

Bitcoin Cash P2P SPV Wallet
MIT License
73 stars 27 forks source link

Build failure with go1.9 #9

Closed bvk closed 6 years ago

bvk commented 6 years ago

I wanted to try this package, but I got the following build failure. Not sure if BCH addresses can be type casted to BTC addresses. Also, build instructions in README doesn't work cause go-get doesn't take https:// URL prefix.

bvk@iron:~/go/src/github.com/cpacia/BitcoinCash-Wallet$ make install
cd cmd/bitcoincash && go install
# github.com/cpacia/bchutil
../../../bchutil/sign.go:195:3: cannot use addresses (type []"github.com/btcsuite/btcd/vendor/github.com/btcsuite/btcutil".Address) as type []"github.com/btcsuite/btcutil".Address in return argument
../../../bchutil/sign.go:202:3: cannot use addresses (type []"github.com/btcsuite/btcd/vendor/github.com/btcsuite/btcutil".Address) as type []"github.com/btcsuite/btcutil".Address in return argument
../../../bchutil/sign.go:204:28: cannot use addresses (type []"github.com/btcsuite/btcd/vendor/github.com/btcsuite/btcutil".Address) as type []"github.com/btcsuite/btcutil".Address in argument to signMultiSig
../../../bchutil/sign.go:206:3: cannot use addresses (type []"github.com/btcsuite/btcd/vendor/github.com/btcsuite/btcutil".Address) as type []"github.com/btcsuite/btcutil".Address in return argument
makefile:2: recipe for target 'install' failed
make: *** [install] Error 2
bvk@iron:~/go/src/github.com/cpacia/BitcoinCash-Wallet$ 
bvk commented 6 years ago

I think above issue was because btcd uses glide tool which created vendor directories. I removed btcd/vendor directory manually and make install worked fine. So, I am closing this ticket.

But, build instructions in README still doesn't work because go-get doesn't take https:// URL prefix.