RTS fixes - Githubissues

Adesin-fr commented 2 years ago

Hi,

This pull request addresses two issues :

RFM69 was not initialized with the frequency set in parameters. This was not a problem for RTS, but it makes more complex to understand why the radio doesn't records RTS data since the radio was on the wrong frequency.
The Plugin_017 (RTS) was crashing when sending data, because of Multiply variable being equal to zero (don't ask me why !), and because the for loop in sendFrame exit test was never met (I'm not sure about the reason, but adding parenthesis to the ternary test did fix it).
Also, the Rolling code in the Plugin_017 was incremented after save, so was never saved with the correct value.

I did test all those modifications on my Somfy stores, they seems to work correctly. However, I don't have any other harware to test other plugins.

Adesin-fr commented 2 years ago

PS : just seen #39 which is about the Multiply variable !

Adesin-fr commented 2 years ago

Added a commit : The Ser2Net plugin uses executeCliCommand with a string, but almost all TX plugins do rely on InputBuffer_Serial, which is not initialized. So, without this fix, TX using Ser2Net doesn't work ;)

cpainchaud commented 2 years ago

thank you for your contribution!

cpainchaud / RFLink32

RTS fixes #43