Applied schmurtzm patches for SONOFF-RF-Bridge

cpainchaud / RFLink32

RFLink for ESP, with MQTT client

Other

119 stars 44 forks source link

Applied schmurtzm patches for SONOFF-RF-Bridge #55

Closed pstzh closed 1 year ago

pstzh commented 2 years ago

start with latest master branch of [RFLink32]
applied all patches from schmurtzm using precompiler switch SONOFF_RFBRIDGE with small beautifying
created a new UI repository https://github.com/pstzh/rflink-webui.git#main (for new auth config)
testet on RFBridge R2 V2.2 with hardware mod

cpainchaud commented 2 years ago

This is a very good job, I am reviewing it at the moment and will make inline comments

cpainchaud commented 2 years ago

@pstzh did you have time to evaluate and fix the code ?

pstzh commented 2 years ago

Sorry - i'm probably too silly to see your inline comments - therefore i don't know what to evaluate and fix. At least my sonoff-rf-bridge run's since 29 days without any problems. can you give me a hint, where and how i can see your comments?

simonhyde commented 1 year ago

I also can't see any inline comments, did they actually get submitted?

cpainchaud commented 1 year ago

I took a different path and have now sonoff in official build , see platformio.ini

pstzh commented 1 year ago

Thank you for integrating Sonoff-RF-Bridge-Direct into RFLink32-master. I testet it on my RF-Bridges and it works (as it did now for one year with my resp. schmurtzm solution ;-) So far OK for me - What I still miss is your answer to my question of Mai 14 2022, which was also commented by simonhyde on Sept. 17. I never saw your inline comments - probably you did not publish? - And you never gave an answer, which is not usual among developers. - A small comment, why you took the differnt pass, would also be the way, how communication and documentation is proper.

cpainchaud commented 1 year ago

Well sorry if I missed that comment and forgot to reply.

All merge request can be commented for review inline to spark discussions... they show here here in plain sight:

simonhyde commented 1 year ago

Well sorry if I missed that comment and forgot to reply.

All merge request can be commented for review inline to spark discussions... they show here here in plain sight:

Those all have a "Pending" logos next to them. I don't think they were ever submitted. Only you @cpainchaud can see them, until you submit the review. Take a look at this page in Incognito/Private mode and you'll see they don't exist for anyone else. I think you can do this by hitting "View changes" next to the top Pending logo, and hitting the "Review Changes" button in the top-right, followed by "Submit Review"....

cpainchaud commented 1 year ago

you must be right, i see it's pending ! My fault!

pstzh commented 1 year ago

thank you both for clarification - finally my goal was to integrate sonoff rf support in this project which has been done now.