search

cpan-authors / IPC-Run

https://metacpan.org/pod/IPC::Run
Other
21 stars 38 forks source link

Fix bitrot in "windows" workflow. #144

Closed nmisch closed 3 years ago

nmisch commented 3 years ago

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands withdrew support for ##[add-path]. The runner image already has strawberryperl in its path, so just remove step Set up Perl.

At first, I just translated the old code to comply with newer guidance. That yielded:

choco install strawberryperl
"C:\strawberry\perl\bin" >>$Env:GITHUB_PATH
"C:\strawberry\perl\site\bin" >>$Env:GITHUB_PATH
"C:\strawberry\c\bin" >>$Env:GITHUB_PATH

However, I then found strawberryperl installed by default. I almost kept the step in the interest of future proofing, but it's by far the slowest part of the workflow.

mohawk2 commented 3 years ago

Thanks!