search

cpan-authors / IPC-Run

https://metacpan.org/pod/IPC::Run
Other
21 stars 38 forks source link

Make t/pty.t test pass on OpenBSD. #150

Closed bluhm closed 2 years ago

bluhm commented 3 years ago

OpenBSD libc devname(3) opens /var/run/dev.db and keeps it open. As this would confuse open file descriptor checks, open it in advance.

nmisch commented 3 years ago

Line 119 does the same thing, but it's part of a block skipped on OpenBSD. Instead of adding a second instance, I recommend moving lines 117-120 above the SKIP block and expanding the comment to mention the OpenBSD need.

On Wed, Sep 08, 2021 at 02:31:06PM -0700, Alexander Bluhm wrote:

OpenBSD libc devname(3) opens /var/run/dev.db and keeps it open. As this would confuse open file descriptor checks, open it in advance. You can view, comment on, or merge this pull request online at:

https://github.com/toddr/IPC-Run/pull/150

-- Commit Summary --

  • Make t/pty.t test pass on OpenBSD.

-- File Changes --

M t/pty.t (4)

-- Patch Links --

https://github.com/toddr/IPC-Run/pull/150.patch https://github.com/toddr/IPC-Run/pull/150.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/toddr/IPC-Run/pull/150

nmisch commented 3 years ago

Looks good. Maintainers: I recommend merging this.