cpan-authors / IPC-Run

https://metacpan.org/pod/IPC::Run
Other
21 stars 38 forks source link

PATHEXT logic bug if cmd_name contains 5.11.1 [rt.cpan.org #50739] #80

Closed toddr closed 6 years ago

toddr commented 7 years ago

Migrated from rt.cpan.org#50739 (status was 'open')

Requestors:

Attachments:

From on 2009-10-22 08:18:17:

( $cmd_name !~ /\..+$/ )  ## Only run if cmd_name has no extension?

will match '.11.1/perl' if
$cmd_name = 'C:/perl/5.11.1/perl';

See attached patch-IPC-Run-0.84-IPC-Run-0.8401.txt

From toddr@cpan.org on 2010-03-22 23:27:48:

On Thu Oct 22 04:18:17 2009, noreply wrote:
> 
> ( $cmd_name !~ /\..+$/ )  ## Only run if cmd_name has no extension?
> 
> will match '.11.1/perl' if
> $cmd_name = 'C:/perl/5.11.1/perl';
> 
> See attached patch-IPC-Run-0.84-IPC-Run-0.8401.txt

Hi, looking at your patch, can you tell me the purpose of the proposed 
changes in the diff for lib/IPC/Run/Win32IO.pm?

From toddr@cpan.org on 2010-03-22 23:46:58:

Fix will be in 0.85 but I'm leaving this ticket open to make a test for now.

From toddr@cpan.org on 2010-03-23 04:04:31:

I put a basic test together to prove the new functionality of the regex for 
_search_path

From dolmen@cpan.org on 2011-03-25 18:29:11:

Le 2010-03-22 19:27:48, TODDR a écrit :
> Hi, looking at your patch, can you tell me the purpose of the proposed 
> changes in the diff for lib/IPC/Run/Win32IO.pm?

That part of the patch does not seem related to this issue.
It has been reported as an other issue: 49693 (security patch for
lib\IPC\Run\Win32IO.pm s/INADDR_ANY/$loopback/)

-- 
Olivier Mengué - http://search.cpan.org/~dolmen/ http://github.com/dolmen/
toddr commented 6 years ago

These changes are already in the repo. closing unless someone knows why it's open.