dagolden
commented
9 years ago Thanks. Mostly I like it. I have a couple things I'd like to see changed, though, before merging.
- the logic for when to add the AUTOMATED_TESTING comment is really convoluted (the phrase shows up in two spots). I think that needs to be simplified.
- I'd like to see this done without a module for the file slurp. While we haven't always been good about it in the past, I want to avoid module dependencies.
Sorry for the delay in getting back to you.
jmaslak
This is my second attempt at this - I believe this one will actually pass the TravisCI build.
I implemented this in a way that keeps the smoke text "notice" but adds the contents of comment.txt to the report when doing automated testing. When doing interactive testing, it will replace the default comment text.
I'm glad to take feedback about this and modify this if you like the idea but not the implementation.
I don't think there is much controversial here except perhaps the choice to add File::Slurper to the list of pre-requisites this module depends on. If you don't like that choice, let me know what your preferred alternative module is or that I should implement a simple open, read, close routine (and similar for write).