cpan-testers / CPAN-Reporter

(Perl) Adds CPAN Testers reporting to CPAN.pm
http://search.cpan.org/dist/CPAN-Reporter/
20 stars 18 forks source link

Use Unix script command instead of IO::CaptureOutput [rt.cpan.org #34526] #74

Open xdg opened 8 years ago

xdg commented 8 years ago

https://rt.cpan.org/Ticket/Display.html?id=34526

On system with a working script(1) command it could be preferable to use
this command instead of IO::CaptureOutput. It seems that script is
perfectly emulating a terminal while capturing all of the output. I made
a test with the Curses::Widgets testsuite and it does not garble the screen.

Regards,
    Slaven
jkeenan commented 1 year ago

https://rt.cpan.org/Ticket/Display.html?id=34526

On system with a working script(1) command it could be preferable to use
this command instead of IO::CaptureOutput. It seems that script is
perfectly emulating a terminal while capturing all of the output. I made
a test with the Curses::Widgets testsuite and it does not garble the screen.

Regards,
    Slaven

Consistent with @xdg's deprecation of IO::CaptureOutput in favor of Capture::Tiny, IO::CaptureOutput was removed by @garu as a prerequisite for CPAN::Reporter in this recent commit (and CPAN release 1.2019):

$ gitshowf 678c241afcac00d712dda76e21dc955c437b185d
commit 678c241afcac00d712dda76e21dc955c437b185d
Merge: e4ed990 ef86b51
Author:     Breno G. de Oliveira <garu@cpan.org>
AuthorDate: Mon May 1 02:49:30 2023 +0200
Commit:     GitHub <noreply@github.com>
CommitDate: Mon May 1 02:49:30 2023 +0200

    Merge pull request #97 from jjatria/capture-tiny

    Use Capture::Tiny instead of IO::CaptureOutput

Can this ticket be closed?