search

cpan-testers / CPAN-Reporter

(Perl) Adds CPAN Testers reporting to CPAN.pm
http://search.cpan.org/dist/CPAN-Reporter/
20 stars 18 forks source link

Eliminate dependency on File::Copy::Recursive. #90

Closed jkeenan closed 6 years ago

jkeenan commented 6 years ago

Instead use fcopy() and dircopy() from File::Copy::Recursive::Reduced, which provide sufficient functionality for the purpose of the CPAN-Reporter test suite and which tests and installs satisfactorily on FreeBSD.

See: https://github.com/cpan-testers/CPAN-Reporter/issues/88

jkeenan commented 6 years ago

Last night File-Copy-Recursive's author made a new CPAN release, version 0.41 which incorporated Tom Hukin's patch and addressed the specific problem raised in https://github.com/cpan-testers/CPAN-Reporter/issues/88. However, that release is failing on many CPANtesters rigs for other reasons. Hence, a new CPAN release of that library will be needed before CPAN-Reporter can once again be reached once again by cpan or cpanm or during Blead-Breaks-CPAN-focused testing.

If such a new release of FCR is not forthcoming, you should still consider this pull request.

Thank you very much. Jim Keenan

garu commented 6 years ago

@jkeenan thanks for the PR! I have merged #91 which fixes the issue without the non-core dependency. The reasoning behind this decision is to keep the test environment as clean of non-core deps as possible.