search

cpan-testers / cpantesters-backend

Backend data processing for CPAN Testers
Other
0 stars 4 forks source link

Use MySQL version 5.7 in Travis tests #18

Closed paultcochrane closed 6 years ago

paultcochrane commented 6 years ago

... since this version supports the JSON field and hence would allow the tests to pass. Also, reinstalling MySQL solves a strange error which looks like it's only associated with Travis and the MySQL version that comes preinstalled on a build VM: when Test::mysqld tries to initialise, it uses mysql_install_db internally, which for some reason tries to find my-default.cnf, which doesn't exist, hence an error is thrown and the tests fail. If one installs one's own MySQL version, then this issue disappears.

Note that this patch requires #16 in order for the tests to pass on Travis. The inspiration for the current solution came from how Test::mysqld installs MySQL (and different versions thereof). If you're happy with this patch, then I can extend the install script to handle more MySQL versions.

preaction commented 6 years ago

... The "Resolve Conflicts" button on Github helped me to completely screw this up, so I merged it from the command-line. I also moved the install script from author/ to xt/ for organizational purposes.

Thanks!