cpanel / elevate

elevate your cPanel&WHM CentOS 7 server to Almalinux 8
https://cpanel.github.io/elevate/
BSD 2-Clause "Simplified" License
45 stars 29 forks source link

Convert CCS blocker to component #411

Closed cPholloway closed 4 months ago

cPholloway commented 5 months ago
Case RE-78: This change converts the CCS blocker to a component.

* Remove the CCS blocker
* Export the CCS data to a secure directory prior to starting leapp
* Remove the CCS package prior to starting leapp
* Remove some cruft that the CCS package leaves behind prior to leapp
* Install the CCS package after leapp completes
* Import the CCS data after leapp completes

Changelog: Convert CCS blocker to component

By submitting pull requests to this repo, I agree to the Contributor License Agreement which can be found at: https://github.com/cpanel/elevate/blob/main/docs/cPanel-CLA.pdf

cPholloway commented 4 months ago

^ this is just the rebase on main

troglodyne commented 4 months ago

So, my only overall commentary about this is mostly about ways this could have potentially been made faster/simpler. Basically this is just running the pkgacct processes I already had code for and then the restorepkg bits after restore, which should work, but is a bit "inefficient" in our context. Testing on a server with an obnoxious amount of users and data and a server with very few users/data is as such advisable from a performance standpoint. I'm not actually sure whether the amount of inefficiency here will actually matter.

That said, doing the following would have been simpler/more efficient execution-wise (but taken more time to code potentially?):

troglodyne commented 4 months ago

If we wind up needing to do pg_dump for customer DB migration, then we probably should revisit this component to share code for that in the future.

cPholloway commented 4 months ago

^ this is just a rebase on main

cPholloway commented 4 months ago

^ rebase on main