search

cpanel / elevate

elevate your cPanel&WHM CentOS 7 server to Almalinux 8
https://cpanel.github.io/elevate/
BSD 2-Clause "Simplified" License
45 stars 30 forks source link

Convert bash pipeline scripts to PERL. #504

Closed davelcpanelnet closed 1 month ago

davelcpanelnet commented 2 months ago

There were 3 scripts originally done in BASH that i wanted to convert over to PERL for more flexibility and control.

davelcpanelnet commented 2 months ago

https://github.com/cpanel/elevate/actions/runs/10693725730/job/29645442689 show this one passing.

davelcpanelnet commented 1 month ago

In my head only compiled binaries get no extension.

happy to make that change.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Todd Rinaldo @.> Sent: Wednesday, September 4, 2024 9:48:09 AM To: cpanel/elevate @.> Cc: David Lanning @.>; Author @.> Subject: Re: [cpanel/elevate] Convert bash pipeline scripts to PERL. (PR #504)

@toddr requested changes on this pull request.

In .github/workflows/openstack.ymlhttps://github.com/cpanel/elevate/pull/504#discussion_r1743942468:

         script: |

cp -pv /opt/elevate/elevate-cpanel /scripts/elevate-cpanel

  • cp -pv /opt/elevate/.github/workflows/openstack/status_marker.sh /scripts/status_marker.sh
  • cp -pv /opt/elevate/.github/workflows/openstack/reboot_watch.sh /scripts/reboot_watch.sh
  • cp -pv /opt/elevate/.github/workflows/openstack/status_marker.pl /scripts/status_marker.pl

Why end in pl or sh? That's not a relevant detail and just leads to more change like here I suggest stripping the extension

— Reply to this email directly, view it on GitHubhttps://github.com/cpanel/elevate/pull/504#pullrequestreview-2280456600, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARWT3JZSFVAX6YY6FCY3F7DZU4MSTAVCNFSM6AAAAABNSWHMFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOBQGQ2TMNRQGA. You are receiving this because you authored the thread.Message ID: @.***>