search

cpanel / perl-compiler

cPanel's custom implementation of B::C
https://cpanel.net
Other
8 stars 3 forks source link

Removed patches and updated docs #87

Closed EvanCarroll closed 2 years ago

EvanCarroll commented 3 years ago

We had two patch sets for B::C one in Patches and RPMS (which was totally undocumented) and then that same patch set duplicated in the docker-perl-compiler repo. Now we link the two together and specify that this will not compile against system perl.

atoomic commented 3 years ago

We can remove the patches. The goal of listing the patches here was to let anyone use this version of the perl-compiler after patching Perl with the provided patches.

This is true that the docker version of Perl is using a complete patch set. But not sure it's really a duplicate, and why the listed patches here are an issue. But once again, I see no problems dropping them.

We should probably be more clear in the README.md about the requirement of patching Perl with the list of patches that you are now removing...

EvanCarroll commented 3 years ago

The exact text I added after Todd clarified what I was doing wrong is,

Moreover, this will likely not work on system perl, as it requires Perl to be both single threaded and compiled with a specific patch set.

If the purpose of this patch set vs the one in docker-perl-compiler was to say that this patch set is required while the other is recommended then I could revert the deletions and clarify the docs. I just didn't want multiple sources of truth for the patch set if we're only supporting one of them, and provide no guidance on either.

atoomic commented 3 years ago

This patch set provides (or was providing) the minimal set of patches to use perl-compiler. You cannot use the current perl-compiler without patching Perl. The docker image used for testing is setup with a perl version customized for cPanel. (this includes this minimal list of patches among some extra).

Removing the patches from this repo, would make it impossible or harder for anyone trying to use this version of the perl-compiler.

atoomic commented 2 years ago

the useless patches are going to be removed in the next branch for 5.35