cpanel / perl-compiler

cPanel's custom implementation of B::C
https://cpanel.net
Other
8 stars 3 forks source link

Freeze PL_sv_zero properly #91

Open toddr opened 2 years ago

atoomic commented 2 years ago

note: PL_Zero is the PV of PL_sv_zero We probably want to freeze PL_sv_zero in this case

atoomic commented 2 years ago

need to check for other special SVs*

atoomic commented 2 years ago

B::SPECIAL should already take care of these PL_*

atoomic commented 2 years ago

from B

 our @specialsv_name = qw(Nullsv &PL_sv_undef &PL_sv_yes &PL_sv_no
             (SV*)pWARN_ALL (SV*)pWARN_NONE (SV*)pWARN_STD
                         &PL_sv_zero);
atoomic commented 2 years ago

idea: check for common PVs strings when generating a COWPV and die or warn on generic PVX like Zero, Yes, No... as this is either an indication we are not using the global PL_sv* or that we should use the PVX from it