search

cpants / www-cpants

cpants tools
Other
21 stars 6 forks source link

SpamcupNG fails Kwalitee due "main_module_version_matches_dist_version" #97

Closed glasswalk3r closed 6 years ago

glasswalk3r commented 6 years ago

SpamcupNG fails the core test "main_module_version_matches_dist_version", but the distribution version indeed matches the main module (there is only one actually) version, as you can see in the attached screenshot. As far as I could check, all files that mention version (Meta*, dist.ini, Makefile.PL) also mentions "1.0" as the version, so I'm not sure if I missing something, or there is an error with Kwalitee reports. 2018-03-12 11_24_03-cpants

charsbar commented 6 years ago

This is because the case of the first letter of your distribution (spamcupNG) doesn't match the one of the module (SpamcupNG), thus CPANTS (correctly) fails to find the "main module" of your distribution. Since a few years ago, PAUSE (and CPANTS) has been stricter about the case of names. Certainly there's a room to improve this error message.

glasswalk3r commented 6 years ago

Got it. I'm considering renaming the distribution to App::SpamcupNG, so that should be fixed as well, so probably you will want to close this issue too.

glasswalk3r commented 6 years ago

@charsbar , where exactly this error message could be improved? I already checked CPANTS and this project itself, but couldn't find the error or the sub name.

charsbar commented 6 years ago

@glasswalk3r https://github.com/cpants/Module-CPANTS-SiteKwalitee/blob/master/lib/Module/CPANTS/SiteKwalitee/Version.pm#L99-L133

Patches are always welcome.

glasswalk3r commented 6 years ago

Done! See https://github.com/cpants/Module-CPANTS-SiteKwalitee/pull/6

charsbar commented 6 years ago

Thanks! Updated the site.