cparnot / ASCIImage

Create UIImage / NSImage instances with NSString and ASCII art
MIT License
1.52k stars 76 forks source link

Added CocoaPods support #13

Closed esttorhe closed 9 years ago

esttorhe commented 9 years ago

Fix #4

Hi there; sorry it took me so long from your tweet but I've been kind of busy lately :see_no_evil:

Ok; long story short; I added support for CocoaPods here; its up and running with Travis and the build is passing :sweat_smile:

Done


Hope this is all well :sparkles:

MRW It finally flushes

esttorhe commented 9 years ago

PS. Let me know if you would like me to rebase all the commits into one single clean one and I'll gladly do it :bow:

cparnot commented 9 years ago

@esttorhe This is great, thanks! I am testing out the branch for the PR and running into some compiler errors, but I'll work it out to figure out what needs to be tweaked.

esttorhe commented 9 years ago

Well; in order for you to test you'll need to have CocoaPods installed on your machine

gem install cocoapods

And then inside the Example folder run

pod install

Then open up the Workspace and that should do the trick.

Let me know if you need any help :)

cparnot commented 9 years ago

Do you mean it won't compile or run the tests without cocoapods installed?

esttorhe commented 9 years ago

Yeah; sadly I realized that was going to be a problem when I was checking #4

Now that I think about it I think it would be safe to leave the project as it was and only add the pods configuration; the problem is that I thought the projects were an Example but in reality they are just the test suites.

Perhaps I'll create a simple "example" project and will add it to the Example folder for the pod.

This is because users can run

pod try ASCIImage

And they get the Example project; I'll update this PR with that new approach if you like it.

cparnot commented 9 years ago

OK, indeed, I would really prefer that the project can be compiled for tests without cocoapod installed. I am totally fine with a cocoapods-specific example project. Thanks a lot for your patience, and sorry I have been slow to respond.

esttorhe commented 9 years ago

OK @cparnot; I fixed the project.

I "reverted" back to your project's structure (Core, App-iOS, App-OSX & Tests) at the root and the Example project for CocoaPods uses those same files but configured to use the pod.

That way there's no duplication of code and both versions compile and run the tests (one needing the pod the other as always).

Hopefully this will be good to go :trophy:

esttorhe commented 9 years ago

Also here's the TravisCI build with all tests in :green_heart:

cparnot commented 9 years ago

All good, thanks!

cparnot commented 9 years ago

@esttorhe Actually, what do you need me to do in the TODO list you had set up above?

esttorhe commented 9 years ago

@cparnot you'll need to push a tag 1.0.0 is the tag set on the podspec if you want to push a different version instead you'll have to update the ASCIImage.podspec version.

Then you'll have to install CocoaPods and push the podspec to trunk (this to make the pod publicly available and to claim it as your own) and that would be it.

cparnot commented 9 years ago

@esttorhe Thanks again for all this! The tag has been added and the pod trunk push command executed.

esttorhe commented 9 years ago

It's alive! :+1:

screen shot 2015-05-05 at 15 00 44

Thanks for bearing with me during the multiple iterations of this PR :bow:

cparnot commented 9 years ago

Thanks for being patient ;-)