search

cpatrickalves / scraping-ebay

Scraping Ebay's products using Scrapy Web Crawling Framework
MIT License
117 stars 40 forks source link

Merge duplicate scraper code #8

Open xloem opened 3 years ago

xloem commented 3 years ago

The files in scrapers/ contain almost the same code.

This means if features are added to one (like adding seller information) they aren't added to the other.

It would be good to pull similar code out of them and reuse it by reference, or pull out and parameterize the differences between them.

cpatrickalves commented 3 years ago

The files with _au_ in the name are for eBay of Australia. The two files for Australia could be merged, I'll do this in the future.

Unfortunately, I don't have time to update this code now.

Thanks anyway.