cpaulik / emacs-material-theme

Color Theme for emacs based on material design colors
MIT License
419 stars 48 forks source link

Better readability of backticks in shell scripts (light theme) #20

Closed mnick closed 9 years ago

mnick commented 9 years ago

Another minor change to improve the readability of the light theme. Changes the color of backticks in shell scripts from gold (on white) to dark cyan (on white).

There are a few more instances of yellow on white faces. Do you have any suggestions to deal with them in a systematic way?

cpaulik commented 9 years ago

I'll look into the yellow faces later. Thanks for making me aware of this. I personally don't use the light theme as often as the dark one. So things go unnoticed longer.

cpaulik commented 9 years ago

I will try to just move the definition of yellow more into orange and move orange to a darker orange. I will also have to look at it on another display since the yellow on white is actually readable on my laptop.

I'm not in favor of changing the preprocessor face to the same color as the function definition.

cpaulik commented 9 years ago

I've now pushed some darker colors for yellow, orange and red.

Please try them and let me know if this is readable to you. If not I'll just try to remove the yellow altogether.

mnick commented 9 years ago

The new colors are definitely better, thanks! The contrast is reduced now, but better the readability trumps that easily.