term-color-white does not show up at all because its foreground color is set to background

cpaulik / emacs-material-theme

Color Theme for emacs based on material design colors

MIT License

416 stars 48 forks source link

Open colonelpanic8 opened 8 years ago

colonelpanic8 commented 8 years ago

Is this on purpose?

Should it actually read

`(term-color-white   ((,class (:foreground ,foreground :background ,background))))

colonelpanic8 commented 8 years ago

Created #31 in case this Is what was intended.

cpaulik commented 8 years ago

I'm not 100% sure. Do you have an example of when this face is used? The original color defined in term.el is:

(defface term-color-white
  '((t :foreground "white" :background "white"))
  "Face used to render white color code."
  :group 'term)

So I think that it is fine if foreground and background have the same color.