search

cpaulik / emacs-material-theme

Color Theme for emacs based on material design colors
MIT License
416 stars 48 forks source link

Updated material-theme with more usable and subtle colors for ediff #48

Closed howdypierce closed 3 years ago

howdypierce commented 3 years ago

Previous colors were garish and not legible when in ediff mode. The unhighlighted regions (what ediff calls the "ediff-odd" and "ediff-even" faces) were particularly illegible. Addressed this with some more subtle colors. Attached screenshots show "before" and "after" on a 3-way merge.

material-ediff-before material-ediff-now

cpaulik commented 3 years ago

Thanks. That looks much better.

cpaulik commented 3 years ago

I had to revert https://github.com/cpaulik/emacs-material-theme/commit/11e525cba2d9cef6ba3ffba6190fb274d0aa56b9

Didn't notice before that that was also included.

howdypierce commented 3 years ago

Thanks. Sorry about the other changes -- I did not expect that those were of interest for general consumption. I thought when I made a pull-request that it was specific to a particular commit in time, but evidently not.

cpaulik commented 3 years ago

No problem at all. I should have checked closer before merging.

MR are related to a branch. It's handy for adding changes during review for example.