search

cpaxton / costar_stack

Integrated ROS capabilities for planning, predicate inference, gripper control, and perception for use with the KUKA LBR IIWA and Universal Robots.
http://cpaxton.github.io/2016/04/15/costar/
Other
86 stars 25 forks source link

Feature/ui #95

Closed cpaxton closed 7 years ago

cpaxton commented 7 years ago

This change is Reviewable

ahundt commented 7 years ago

wow this is intense, has this branch just been going on for a very long time?

cpaxton commented 7 years ago

Yes it needs to be merged

Best, Chris

Sent from my phone

From: Andrew Hundt notifications@github.com Sent: Thursday, September 21, 2017 11:11:16 PM To: cpaxton/costar_stack Cc: Chris Paxton; Author Subject: Re: [cpaxton/costar_stack] Feature/ui (#95)

wow this is intense, has this branch just been going on for a very long time?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cpaxton/costar_stack/pull/95#issuecomment-331359315, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADImZ02cEVIKDlzNVTG_aWuD2SUDJtOmks5sk0-EgaJpZM4OxKVg.

ahundt commented 7 years ago

I looked through it and this seems pretty good overall to me. I don't think such a big and well tested PR is worth nitpicking.