search

cpb- / yocto-cooker

Meta buildtool for Yocto Project based Linux embedded systems
GNU General Public License v2.0
43 stars 22 forks source link

[FIX] Bad path in variable TEMPLATE_CONF in class PokyDistro #135

Closed ever3001 closed 1 year ago

ever3001 commented 1 year ago

The new versions of poky uses meta-poky/conf/templates/default instead of meta-poky/conf as the path for the template file (Changed in commit c472d9ba9e970ad4c9bacf7851fcf6245fd03c40)

This is causing an error and preventing to use yocto-cooker with the new versions of poky.

Issue to resolve: #134

pboettch commented 1 year ago

Thanks for your contribution. Could you add a test?

ever3001 commented 1 year ago

Thanks for your contribution. Could you add a test?

Hello @pboettch,

I can add a test for the code I created, but I have a concern. The fix for the bug I discovered involves returning the first path found within the "poky" folder. This requires the "poky" folder to be present. There are two options for ensuring this:

1) clone the "poky" repository, which takes a significant amount of time and must be done each time the test is run, or 2) simulate the cloning by creating the necessary folders.

Which option do you think is the best?

pboettch commented 1 year ago

Yes. No.

Do not clone poky.

Just create the necessary (even empty) files in your test-script and run cooker init and cooker generate (without update) to say whether the local/bblayers.conf are created correctly.

As an example, see: https://github.com/cpb-/yocto-cooker/blob/master/test/basic/generate/test

You could even add your test in this files (at the end).