cpbotha / nvpy

Simplenote syncing note-taking application, inspired by Notational Velocity and ResophNotes, but uglier and cross-platformerer.
Other
849 stars 114 forks source link

Support for createdate based sorting. #122

Closed LeHack closed 9 years ago

LeHack commented 9 years ago

Hello, first of all, I really like your application and I've been using it for the last 2 years to manage my training/lecture/programming notes. Over that time I found that I could use a couple additional features, hence I decided to go ahead and give it a shot with my basic python skills (always a good chance to work on that as well).

The main change I needed was to be able to have the notes sorted by date of creation, rather than date of last modification. I also took care of two minor issues I found:

Finally (since I'm using eclipse) I added a .gitignore file with some basic ignores to make it simpler for myself to work with this project. I hope you don't mind.

Now I'm planning to add an in-program base directory (category?) switching so the user can have a few easily accessible groups of notes instead of having it all in one common directory (~/.nvpy).

Anyway thank you for creating nvpy and I hope you like my changes. If you have any pointers regarding my coding style please don't hesitate to let me know. I'll be grateful for any critique that can help me learn to code better in Python :)

Best regards LeHack

cpbotha commented 9 years ago

Have briefly checked, looks good.

One point of improvement:

key in dict does work and is much faster than key in dict.keys()