Closed george-thomas-hill closed 3 years ago
Thanks for submitting Merge Requests. It's a good proposal to move infrequently used options to the menu. I also agree that nvPY has room for improvement in the focus order of UI components. However, I disagree with the following opinion.
Therefore, this pull request creates a streamline_interface option that can be set in .nvpy.cfg.
It defaults to false, but when set to be true, it prevents the "CS" checkbox, the search-style dropdown, the sort-by dropdown, the "pinned" checkbox, and the add-tags tool all from being rendered. This takes those options out of the tab order and allows the user to quickly tab between the search box and the selected note. Having this option will be appealing to a user who doesn't use those features.
We can focus the note editor quickly by hitting the enter key on the search box. Don't have to use the tab key, excluding corner cases.
Thank you so much for merging this code submission!
Right now, hitting tab when in the search box sends the focus first to the "CS" checkbox, then to the search-style dropdown, then to the sort-by dropdown, then to the "pinned" checkbox, then to the add-tags tool—and only then to the selected note.
Hitting shift+tab sends the user backwards along the same long path.
All these stops along the way in the tab order are rarely used options that keep the user from quickly tabbing between the search box and the selected note.
These rarely used options also contribute to nvPY's alleged ugliness by cluttering up the interface, contrary to the spirit of the original Notational Velocity.
Therefore, this pull request creates a streamline_interface option that can be set in .nvpy.cfg.
It defaults to false, but when set to be true, it prevents the "CS" checkbox, the search-style dropdown, the sort-by dropdown, the "pinned" checkbox, and the add-tags tool all from being rendered. This takes those options out of the tab order and allows the user to quickly tab between the search box and the selected note. Having this option will be appealing to a user who doesn't use those features.
Additionally, this pull request creates a new "Note" menu (to allow the user to set a note as being pinned) and a "Search" menu (to allow the user to set the search mode options).
Thank you for considering these changes.