Fixes layout-related assertions and runtime errors in ProDe

[sarahec]

Redone w/ strictly limited formatting changes. Note that apparent author name replacements are needed due to Visual Studio Code mis-converting the names into UTF-8.

Fixes #140

[sarahec]

The force push was to remove an accidental duplication of a commit.

[sarahec]

And Visual Studio code mangled the names when converting to UTF-8. I fixed them.

[sarahec]

Thanks for letting me know. I'll look at the script and adjust my IDE settings.

On Mon, May 16, 2022, 23:00 Pekka Jääskeläinen @.***> wrote:

@.**** approved this pull request.

Thanks! Outside that minor nitpick looks good. We'll text locally and merge.

In tce/src/procgen/ProDe/AddRFFromHDBDialog.cc https://github.com/cpc/tce/pull/144#discussion_r874395971:

@@ -165,7 +165,7 @@ AddRFFromHDBDialog::AddRFFromHDBDialog( string iconPath = Environment::iconDirPath() + FileSystem::DIRECTORY_SEPARATOR;

• wxImageList* imageList = new wxImageList();
• wxImageList *imageList = new wxImageList(13, 17);

I believe TCE style wants to put the asterisk next to the type. There's a starting point for a formatter script in tools/scripts/format-branch.sh (it's has known issues) which you can try.

— Reply to this email directly, view it on GitHub https://github.com/cpc/tce/pull/144#pullrequestreview-974875676, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWBND3ZUNO5ZWSN6UW4TPDVKMYZJANCNFSM5WC2ODHA . You are receiving this because you authored the thread.Message ID: @.***>

[pjaaskel]

This also has the LLVM build dir added as a submodule for some reason.

[sarahec]

Well, nuts. I thought I had fixed that before submitting. Sorry about that, I'll have to make a clean branch for you.

[sarahec]

Closing this PR, will send you a clean branch. Writing a tool to do the substitutions without changing the coding style.

[pjaaskel]

Did you post the branch somewhere? It seems I have lost it.

[sarahec]

I'm building a tool to apply the changes automatically. Once I run that on ProDe, I'll send you a new branch. (I have a copy of the old branch stored locally so I can diff them and confirm the right changes landed.)

This will speed up upgrading the rest of the tools and ensure that formatting isn't disturbed.

On Thu, Jun 9, 2022 at 6:39 AM Pekka Jääskeläinen @.***> wrote:

Did you post the branch somewhere? It seems I have lost it.

— Reply to this email directly, view it on GitHub https://github.com/cpc/tce/pull/144#issuecomment-1151133136, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWBND6FOMWK5J5L6TPFQ4TVOHXYNANCNFSM5WC2ODHA . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Sarah Clark | Program Manager, IDR Education | @.*** | M: +1.408.605.2653

[pjaaskel]

Sounds good. May I ask what you are (considering) using OpenASIP for?

[sarahec]

At the moment, personal projects with a degree of programmability (e.g. wearables that respond to their environment). But also, I have a standing offer from a couple of conferences anytime I want to come in and teach on FPGA development. The latter is why I'm cleaning up the nits that prevent working on other window managers.

Nothing related to my day job, which is running engineering education.

On Thu, Jun 9, 2022 at 11:49 PM Pekka Jääskeläinen @.***> wrote:

Sounds good. May I ask what you are (considering) using OpenASIP for?

— Reply to this email directly, view it on GitHub https://github.com/cpc/tce/pull/144#issuecomment-1152029087, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWBND2XACB4A77TRZDEZIDVOLQQ7ANCNFSM5WC2ODHA . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Sarah Clark | Program Manager, IDR Education | @.*** | M: +1.408.605.2653

[pjaaskel]

Nice! For the latter you may be interested of this deck I showed in OpenSuco3 / ISC 2018 http://openasip.org/slides/2018-06-TCE-Tour-with-Clickable-Videos.pptx