search

cpc / openasip

Open Application-Specific Instruction Set processor tools (OpenASIP)
http://openasip.org
Other
140 stars 42 forks source link

Should we change the wxWidgets apps to use the system theme? #208

Closed sarahec closed 1 year ago

sarahec commented 1 year ago

TopiLeppanen raises an interesting question in PR #206 -- it's a patch to make the ProDe opcode box work in dark mode by using one of the System colors. wxWidgets uses native controls where available, and its default assumption is that it's using the system theme. Would it make sense to update the apps to match the system settings?

If so, I can update the automated wx patching tool to make these changes.

sarahec commented 1 year ago

P.S. The alternate approach would be to query wxSystemAppearance and choose colors accordingly.

sarahec commented 1 year ago

Never mind, I see we're mostly using the system theme with some local overrides. The overrides may not be needed but we may need to embed some widgets in a sub-window of their own to get the correct background colors.