search

cpc / openasip

Open Application-Specific Instruction Set processor tools (OpenASIP)
http://openasip.org
Other
138 stars 41 forks source link

Improve column renaming for HDB migration 6 #213

Closed nrother closed 1 year ago

nrother commented 1 year ago

Fixes #212

Note that currently no effort is made to fix old databases which may have invalid foreign keys due to the old code. ALTER TABLE RENAME COLUMN was added in version 3.25.0 of SQLite.

pjaaskel commented 1 year ago

Does it break older than 3.25.0 SQLite versions? At least README.md needs to be updated if so. How old is that version, does the oldest alive Ubuntu LTS ship that already?

sarahec commented 1 year ago

Ubuntu 18.04 LTS has MySQL 3.22, see: package repo search for mySQL. EOL is April 2023

pjaaskel commented 1 year ago

@sarahec we are using SQLite, not MySQL, those are two different SQL-based RDBMs.

nrother commented 1 year ago

I think @sarahec had a typo there, both the version and the package query link refer to SQLite.

sarahec commented 1 year ago

Yes, that was a brain slip. It's SQLite 3.22 in Ubuntu 18.04.

pjaaskel commented 1 year ago

20.04 has 3.31 so I guess it's fine since it's only a few months until EOL. LGTM.

pjaaskel commented 1 year ago

Can you update README.md's SQLite minimum version and CHANGES?

nrother commented 1 year ago

Updated the files. I'm not so sure about the minimum version of RHEL that is required now, they don't seem to have public information about their packages.