search

cpc / openasip

Open Application-Specific Instruction Set processor tools (OpenASIP)
http://openasip.org
Other
143 stars 43 forks source link

AlmaIF: Fix a bug in almaif_decoder #232

Closed TopiLeppanen closed 1 year ago

TopiLeppanen commented 1 year ago

There was extra 2 subtracted from on-chip address width when calculating the memory mask to decide whether the memory access is directed to on-chip or to the AXI master. What this caused was that basically only the first quarter of the on-chip memory was actually accessible.

Thankfully this seems to have been fixed by @karihepola in AamuDSP RTL, but didn't seem to get upstreamed back then.

pjaaskel commented 1 year ago

Can you mention this in CHANGES? Did you run all tests?

TopiLeppanen commented 1 year ago

Updated CHANGES.

No, didn't run all the tests. Since this fix is so clearly specific to AlmaIF and on the the RTL-side, I only ran the tests from testsuite/systemtest_long/procgen/PlatformIntegrator/AlmaIFIntegrator, which are the only tests using AlmaIF.