Use time.monotonic()

[ddelange]

Hi!

Just some small improvements I spotted while inspecting this already beautifully lean lib. Fixes #10, closes #13

How does your release flow work? Do you merge to default branch, git tag, and upload to Pypi from there? As an alternative to your versioneer setup, you could use setuptools_scm, designed for this specific purpose. See e.g. https://github.com/john-kurkowski/tldextract/pull/187

Description

time.monotonic() relates to the real time spent inside the main thread, and can not be altered externally by e.g.

• ntp system time synchronisation (frequent, small impact)
• automatic time zone changes (infrequent, big impact)
• users manually changing system time (infrequent, big impact)

and is therefore preferred over time.time when measuring relative times (of a program).

Smaller improvements:

• Remove init with unnecessary instance attribute assignment (time to load the extension itself is now representative due to explicit start() call)
• Use slots for lower memory consumption of class instance(s)
• Simplify stop(), reducing the amount of checks, instance attribute lookups and variable assignments (performance nits)
• Remove, by definition, the need for the assert statement

[ddelange]

@cpcloud as the last release was 2016, what are the chances of this getting reviewed, merged & released by you? i saw some forks arose on pypi, maybe due to inactivity here?

if you're overloaded, do you need help maintaining this lib? it is still used a lot

[cpcloud]

@ddelange I'm definitely interested in having some help maintaining this library. Are you interested?

[ddelange]

definitely would be down :) do you do uploads to pypi manually? if you can give me pypi write access, I could also add Github Actions into the mix to automatically deploy to pypi when a new release/tag is pushed to the repo on master branch (not sure if overkill for this repo tho, can keep doing it manually of course)

[cpcloud]

Alright, I'll add you as a collaborator on the repo along with PyPI perms, doing it now.

[cpcloud]

Actually @ddelange I am apparently not the person who added the PyPI package!

[ddelange]

@amitu could you add us as maintainers on the pypi package so we can release a new version?

[ddelange]

@cpcloud I've sent @amitu an email on his personal gmail in an attempt to reach him.

If we can't reach him for 6 weeks, we can open an issue with a PEP 541 request: https://www.python.org/dev/peps/pep-0541/#reachability

In the meantime, I didn't find a PyPi account for cpcloud. Do you have one/can you create one?

[ddelange]

@amitu just another reminder, please grant us pypi maintainer access so we can release this :)

[amitu]

@ddelange apologies for delayed reply. Who do I give access to?

[ddelange]

Hi @amitu! No worries. As @cpcloud doesn't have a pypi account (yet?), can you add just ddelange for now?

[cpcloud]

My pypi account is Charles.Cloud

[amitu]

I have invited both of you as maintainers. Let me know if someone wants to take over the ownership.

[ddelange]

Thanks @amitu :)