search

cpederkoff / stl-to-voxel

Turn STL files into voxels, images, and videos
MIT License
138 stars 75 forks source link

Recover the ability to paint in the removed isAboveAndBelow() #25

Closed youngkiu closed 3 years ago

youngkiu commented 3 years ago

The improved pixel in https://github.com/cpederkoff/stl-to-voxel/pull/12 disappeared with isAboveAndBelow(). It guarantees pixels up to len(same) == 3 or len(same) == 1 on the z plane.

And additionally, I have improved the following:

  1. I changed the error log in perimeter.py to assert. and I solved the problem at z=133, x=55 of Eiffel_tower_sample.STL, resolution=100
  2. I improved paintPixels() performance without onLine()
  3. The voxel memory is allocated only once, and the slice refers to the plane of this voxel.
youngkiu commented 3 years ago

@cpederkoff I would like to start working on https://github.com/cpederkoff/stl-to-voxel/issues/13 with a new branch from the master branch where https://github.com/cpederkoff/stl-to-voxel/pull/25 is merged. Can I ask for a review?

youngkiu commented 3 years ago

@cpederkoff Could you merge this PR?