cpesch / RouteConverter

The popular GPS conversion and editing tool
http://www.routeconverter.com
Other
141 stars 40 forks source link

Copilot output duplicates Start point during save #86

Open SiWoC opened 4 months ago

SiWoC commented 4 months ago

The issue is no more, no less than the title

image

Code seems to reference a Preference for this, but I don't see the actual point in the code where this duplication occurs.

Data Version:2.14.6.1
Start Trip=Start:Start:Start:An der Kleinbahn 5, 41334 Nettetal to 34 Stran
Creator=Generated by Christian Peschs RouteConverter. Sees http://www.routeconverter.com
TollClosed=0
End Trip

Start Stop=Stop 0
Longitude=6195630
Latitude=51328910
Address=41334 Nettetal
City=Start:Start:Start:An der Kleinbahn 5
Show=1
Sequence=0
End Stop

Start StopOpt=Stop 0
Loaded=1
End StopOpt

Start Stop=Stop 1
Longitude=6195630
Latitude=51328910
Address=41334 Nettetal
City=Start:Start:An der Kleinbahn 5
Show=0
Sequence=1
End Stop

Start StopOpt=Stop 1
Loaded=1
End StopOpt

Start Stop=Stop 2
Longitude=6195630
Latitude=51328910
Address=41334 Nettetal 1
City=Start:An der Kleinbahn 5
Show=0
Sequence=2
End Stop
cpesch commented 4 months ago

This is not a bug, but a feature.

The preference is defined here: https://github.com/cpesch/RouteConverter/blob/a839bcdf2725e5fe088f884ae3e190b7db60e36d/route-converter/src/main/java/slash/navigation/converter/gui/panels/ConvertPanel.java#L691

All hidden options are defined here: https://static.routeconverter.com/download/HiddenRouteConverterOptions.reg

I hope this helps?

SiWoC commented 4 months ago

I don't get it. So when I save a file in those formats, "every time" the startposition gets duplicated? Why would I want that? Maybe you want it when you "convert" from another format to these formats the first time?

Added the reg-key = false to my registry

cpesch commented 1 month ago

The reason is described here and is part of the code base since 2011

Additional bonus: Not a must, but it would be great if it can be easily implemented: It would be good if the first point appeared twice. Once as the starting point and then a second time as a waypoint. Reason: As soon as you load a route list for navigation, it sets the current GPS location of the device as the start point. The original starting point is then discarded, and the route may end up being different from what was planned. If the second point were a copy of the first, this problem should no longer exist.