Groundwork for merging projects

cpetig / tflite_micro_compiler

generate tflite micro code which bypasses the interpreter (directly calls into kernels)

Apache License 2.0

77 stars 26 forks source link

Groundwork for merging projects #1

Closed rafzi closed 4 years ago

rafzi commented 4 years ago

apply google style formatting
add cmake support
code review for compiler.cc

cpetig commented 4 years ago

Thank you for the clean up work! It seems that the strange crash has vanished (probably due to using C++ containers over C FILE and malloc operations), did you locate the problem or just eliminate it by writing more clean code ;-) ?

cpetig commented 4 years ago

valgrind is happy, so am I!

rafzi commented 4 years ago

I did not thoroughly test your base version, but I did encounter some strange crashes. The subgraph pointer in the micro interpreter was not correct and the interpreter crashed on the first operators_size() call. I believe the fix for me was to recompile TF, because the binary might have gotten out of sync with the headers.