cpetig / tflite_micro_compiler

generate tflite micro code which bypasses the interpreter (directly calls into kernels)
Apache License 2.0
77 stars 26 forks source link

custom implementation doesn't pass custom_initial_data_size to Init #17

Closed cpetig closed 4 years ago

cpetig commented 4 years ago

is it necessary to remember the size of the data and pass it to the function? I have never seen that value used.

rafzi commented 4 years ago

The interface requires it, so we should do it. For example I'd maybe add an assert to ensure the size in my custom op.

cpetig commented 4 years ago

see https://github.com/cpetig/tflite_micro_compiler/pull/21#discussion_r435247048

cpetig commented 4 years ago

related to #38