search

cpetig / tflite_micro_compiler

generate tflite micro code which bypasses the interpreter (directly calls into kernels)
Apache License 2.0
76 stars 26 forks source link

Update required define #58

Open rafzi opened 3 years ago

rafzi commented 3 years ago

From SIGMICRO list:

If you explicitly have TF_LITE_STATIC_MEMORY defined in a Make or build config, please update that build define to TF_LITE_MICRO.

cpetig commented 3 years ago

Hi Rafael, do you have a more specific link? I was unable to find it at https://gitter.im/tensorflow/sig-micro . I would like to understand which tf versions are affected how.

cpetig commented 3 years ago

I see tensorflow/lite/micro/tools/make/Makefile in r2.4 still define TF_LITE_STATIC_MEMORY and I see no usage of a TF_LITE_MICRO in r2.4 (as of today)

rafzi commented 3 years ago

I just copied from inbox to issue, but you are right that there seems to be no mention of this flag in the official repo.

https://groups.google.com/a/tensorflow.org/g/micro/c/ExZmKoRzeAs

cpetig commented 3 years ago

That sounds like r2.5 material (also given the time it got posted (after releasing 2.4-rc2)), so I believe it won't affect us for another months (till we create a r2.5 branch). By the way would you agree to remove the branch master from the repository? Besides the obvious issues with the name I think it adds more confusion than it helps. Especially since I created r2.1..r2.4 and made r2.3 the default branch some time ago.

rafzi commented 3 years ago

The master branch still serves a purpose for me, in that I'd use it to keep up with tensorflow master. However we could rename it to "develop"/"dev" to avoid confusion.

cpetig commented 3 years ago

Today I found the info that this rename got delayed: https://groups.google.com/a/tensorflow.org/g/micro/c/ExZmKoRzeAs/m/XoemFLMgAAAJ?pli=1